chore: golangci-lint linting fixes#107
Merged
Merged
Conversation
Emyrk
commented
May 5, 2025
Comment on lines
+23
to
+35
| func asStringsIsDangerous(m dsl.Matcher) { | ||
| m.Import("github.com/zclconf/go-cty/cty") | ||
|
|
||
| m.Match( | ||
| `$v.AsString()`, | ||
| ). | ||
| Where( | ||
| m["v"].Type.Is("cty.Value") && | ||
| // Ignore unit tests | ||
| !m.File().Name.Matches(`_test\.go$`), | ||
| ). | ||
| Report("'AsStrings()' can result in a panic if the type is not known. Ignore this linter with caution") | ||
| } |
Member
Author
There was a problem hiding this comment.
I'm adding this. If misused it is an easy panic. I might continue to add these kinds of "be careful" cty stuff
aslilac
approved these changes
May 5, 2025
Member
aslilac
left a comment
aslilac
left a comment
There was a problem hiding this comment.
I'd rather remove a bunch of this commented out code than leave it, but I'll defer to you on if you wanna take the opportunity now or not
| })) | ||
| var _ = ll | ||
| //tlog.SetDefault(ll) | ||
| // tlog.SetDefault(ll) |
Member
Author
|
@aslilac I need to do a longer look for this dead code. I just missed the ones you commented on 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.